Add build & yalc files to the delete script#71
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
eae4050 to
f56ed43
Compare
f56ed43 to
aecc392
Compare
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 35: The "core:reinstall" npm script currently calls node
./scripts/delete-temp-files.cjs with the destructive "--all" flag which wipes
dev-appdata, caches, builds and forces full rebuilds; update the script
definition for "core:reinstall" to call delete-temp-files.cjs with only the
narrower flags required (e.g. "--npm" and, if yalc cleanup is intended,
"--yalc") instead of "--all" so it performs npm/yalc cleanup only and avoids
wiping dev-appdata, Electron caches, build outputs and other heavy state.
In `@scripts/delete-temp-files.cjs`:
- Around line 67-72: The BUILD_PATHS collection only adds directories from
findDirsNamed for 'dist' and 'temp-build' but misses buildinfo files; update the
shouldDeleteBuild logic (and the analogous block around lines 128-140) to also
collect files matching *buildinfo* under CORE_DIR_PATH (not just directories) —
either extend or add a helper like findPathsMatching(CORE_DIR_PATH,
'*buildinfo*', SKIP_DIRS) and push those file paths into BUILD_PATHS (or a
combined list used for deletion), ensuring you reference the existing symbols
BUILD_PATHS, shouldDeleteBuild, findDirsNamed and CORE_DIR_PATH so the cleanup
removes incremental compiler state as intended.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1ac91d80-01cb-49ce-a26e-58594a212237
📒 Files selected for processing (2)
package.jsonscripts/delete-temp-files.cjs
This change is
Summary by CodeRabbit