Move HasCommit check inside lock in DataModel.Add#66
Conversation
Previously the duplicate-commit check ran before acquiring the repo lock, leaving a TOCTOU window where two concurrent Add calls could both see the commit as missing and proceed to insert it. https://claude.ai/code/session_01TziA3LymLmdxXxUgXywq4B
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bump Harmony submodule to include the in-lock HasCommit check (sillsdev/harmony#66), which closes the TOCTOU race between concurrent AddPredefinedMorphTypes callers on a fresh project (BG sync's CreateProject vs. HTTP middleware's MigrateDb). The MigrateDb pre-check was a small optimization, not a race guard — drop it, let Harmony's in-lock check handle idempotency. Note: won't build on develop until the .NET 10 chore lands (Harmony main is on .NET 10). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 participants
Previously the duplicate-commit check ran before acquiring the repo lock, leaving space for a race condition.