Fix LT-21617: Sorting does not work for Exception Features#896
Merged
Conversation
mark-sil
approved these changes
May 19, 2026
Contributor
mark-sil
left a comment
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jtmaxwell3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-21617. RecordList.ListAlreadySorted was implemented incorrectly, and in any case IsSorted wasn't being updated when a list was reverse sorted. ListAlreadySorted isn't called anywhere else. It is amazing that this code worked at all. My guess is that IsSorted was true for most possibility lists, so the old implementation of ListAlreadySorted worked. But for some reason it wasn't true for Exception Features, and so Exception Features couldn't be sorted.
This change is