Skip to content

LT-22373b: Move numbering style fix to the get method #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aror92 merged 1 commit into from
May 15, 2026
Merged

LT-22373b: Move numbering style fix to the get method #887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Src/xWorks/DictionaryConfigurationController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,10 +520,6 @@ public static void SetConfigureHomographParameters(DictionaryConfigurationModel
var senseNode = mainEntryNode.Children.Where(prop => prop.Label == senseType).FirstOrDefault();
if (senseNode == null) return;
var senseOptions = (DictionaryNodeSenseOptions)senseNode.DictionaryNodeOptions;
if (String.IsNullOrEmpty(senseOptions.NumberingStyle))
{
senseOptions.NumberingStyle = null;
}
cacheHc.ksSenseNumberStyle = senseOptions.NumberingStyle;
//SubSense Node
var subSenseNode = senseNode.Children.Where(prop => prop.Label == "Subsenses").FirstOrDefault();
Expand Down
8 changes: 7 additions & 1 deletion Src/xWorks/DictionaryDetailsView/SenseOptionsView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,13 @@ internal List<NumberingStyleComboItem> NumberingStyles

public string NumberingStyle
{
get{ return ((NumberingStyleComboItem)dropDownNumberingStyle.SelectedItem).FormatString; }
get
{
// Return null if string is empty, because returning an empty string for reversal numbers
// also forces sense numbers not to be displayed. Null doesn't cause the same problem.
var formatString = ((NumberingStyleComboItem)dropDownNumberingStyle.SelectedItem).FormatString;
return string.IsNullOrEmpty(formatString) ? null : formatString;
}
set
{
if (string.IsNullOrEmpty(value))
Expand Down
Loading