feat: add multimodal support to message validation#118
Conversation
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Consider adding validation for array items (e.g., each element should have a type and data) to ensure multimodal payloads are correctly formed. Reviewed — quality: high |
I have strengthened the validation for multimodal array items. Each element in the array is now explicitly checked to be a valid object containing a string |
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
@shenald-dev this PR has merge conflicts with To resolve manually: Alternatively, you can try updating your branch with the latest from |
|
🔄 Re-evaluating based on recent changes: Please resolve the merge conflicts with master before merging. Also consider adding explicit validation for each array element's type and data fields as suggested, and ensure tests cover edge cases. Reviewed — quality: high |
I have successfully fetched and merged |
The merge conflicts with |
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
🔄 Re-evaluating based on recent changes: Please resolve the merge conflicts with master as outlined in the comment. After resolving, ensure the validation for array elements strictly checks that each item is an object with 'type' and 'data' properties, and add tests for malformed multimodal arrays to prevent regressions. Reviewed — quality: medium |
I have updated the validation logic to strictly require that each array element is an object containing both |
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
@shenald-dev this PR has merge conflicts with To resolve manually: Alternatively, you can try updating your branch with the latest from |
I have previously fetched and manually resolved the merge conflicts with |
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
Please resolve the merge conflicts with master as described in the comments. After resolving, ensure that the validation for each array element includes explicit checks for type and data fields, and that tests cover edge cases such as empty arrays, non‑object items, and missing fields. Reviewed — quality: medium |
I have updated the validation logic to reject empty arrays in the |
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
isValidMessageto allow thecontentproperty to be either a string or an array to support multimodal (e.g., Vision) payloads.tests/api.test.jsto assert multimodal array structures are properly validated..jules/bolt.mdto log the optimization and learnings.PR created automatically by Jules for task 16104151899470475087 started by @shenald-dev