Skip to content

Convert compression middleware to route-specific#113

Merged
shenald-dev merged 1 commit into
masterfrom
perf/compression-middleware-16502635405221466179
May 12, 2026
Merged

Convert compression middleware to route-specific#113
shenald-dev merged 1 commit into
masterfrom
perf/compression-middleware-16502635405221466179

Conversation

@shenald-dev
Copy link
Copy Markdown
Owner

Converted the global compression() middleware to a route-specific middleware on the /v1/chat/completions endpoint. This prevents unhandled routes (404s) and lightweight responses from incurring unnecessary CPU overhead and memory allocation for compression. Bumped version to 1.1.32 and updated CHANGELOG.md and ledger files.


PR created automatically by Jules for task 16502635405221466179 started by @shenald-dev

Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@shenald-dev shenald-dev added enhancement New feature or request refactor labels May 12, 2026
@shenald-dev
Copy link
Copy Markdown
Owner Author

Looks good. Ensure there is test coverage verifying that compression is applied only to the /v1/chat/completions endpoint and not to other routes.

Reviewed — quality: high

@shenald-dev
Copy link
Copy Markdown
Owner Author

Looks good, merging this in. CI is green and everything checks out 👍

Move compression middleware to be route-specific for /v1/chat/completions to reduce unnecessary CPU and memory overhead.

@shenald-dev shenald-dev merged commit 5a26f85 into master May 12, 2026
2 checks passed
@google-labs-jules
Copy link
Copy Markdown
Contributor

Looks good. Ensure there is test coverage verifying that compression is applied only to the /v1/chat/completions endpoint and not to other routes.

Reviewed — quality: high

Added explicit tests to verify that compression() is attached to the /v1/chat/completions endpoint and that the /health endpoint is not compressed. Instead of altering the payload size or framework defaults to assert on Content-Encoding, the test cleanly asserts on the Vary header behavior (Accept-Encoding) that the middleware introduces when attached, even if the payload doesn't exceed the threshold.

@google-labs-jules
Copy link
Copy Markdown
Contributor

Looks good, merging this in. CI is green and everything checks out 👍

Move compression middleware to be route-specific for /v1/chat/completions to reduce unnecessary CPU and memory overhead.

Acknowledged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant