Skip to content

perf(cors): move cors before helmet and consolidate res.setHeader#110

Merged
shenald-dev merged 1 commit into
masterfrom
perf/cors-middleware-routing-4250582525074431202
May 4, 2026
Merged

perf(cors): move cors before helmet and consolidate res.setHeader#110
shenald-dev merged 1 commit into
masterfrom
perf/cors-middleware-routing-4250582525074431202

Conversation

@shenald-dev
Copy link
Copy Markdown
Owner

Moves cors() middleware to execute before helmet(). This enables preflight OPTIONS requests to be immediately intercepted and resolved without undergoing unnecessary security header processing, reducing baseline latency and CPU overhead. Also consolidates redundant res.setHeader calls in the JSON error handler into a single call.


PR created automatically by Jules for task 4250582525074431202 started by @shenald-dev

Moves `cors()` middleware to execute before `helmet()`. This enables preflight `OPTIONS` requests to be immediately intercepted and resolved without undergoing unnecessary security header processing, reducing baseline latency and CPU overhead. Also consolidates redundant `res.setHeader` calls in the JSON error handler into a single call.

Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@shenald-dev shenald-dev added enhancement New feature or request refactor labels May 4, 2026
@shenald-dev
Copy link
Copy Markdown
Owner Author

Looks good, merging this in. CI is green and everything checks out 👍

Move CORS middleware before Helmet for faster preflight handling and consolidate duplicate header setting.

@shenald-dev shenald-dev merged commit 00fd156 into master May 4, 2026
2 checks passed
@google-labs-jules
Copy link
Copy Markdown
Contributor

Looks good, merging this in. CI is green and everything checks out 👍

Move CORS middleware before Helmet for faster preflight handling and consolidate duplicate header setting.

Acknowledged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant