perf(cors): move cors before helmet and consolidate res.setHeader#110
Conversation
Moves `cors()` middleware to execute before `helmet()`. This enables preflight `OPTIONS` requests to be immediately intercepted and resolved without undergoing unnecessary security header processing, reducing baseline latency and CPU overhead. Also consolidates redundant `res.setHeader` calls in the JSON error handler into a single call. Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Looks good, merging this in. CI is green and everything checks out 👍 Move CORS middleware before Helmet for faster preflight handling and consolidate duplicate header setting. |
Acknowledged. |
Moves
cors()middleware to execute beforehelmet(). This enables preflightOPTIONSrequests to be immediately intercepted and resolved without undergoing unnecessary security header processing, reducing baseline latency and CPU overhead. Also consolidates redundantres.setHeadercalls in the JSON error handler into a single call.PR created automatically by Jules for task 4250582525074431202 started by @shenald-dev