perf: optimize async coroutine inspection unwrapping#108
Conversation
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Hey @shenald-dev, heads up — this PR has merge conflicts with To fix: |
|
Please resolve the merge conflicts with main before merging. Additionally, consider adding a test case to verify that the optimization does not change behavior for functools.partial-wrapped coroutines and regular functions. Ensure the minimum supported Python version is 3.8+ as assumed. Reviewed — quality: high |
I have successfully fetched and merged |
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
🔄 Re-evaluating based on recent changes: Thanks for the optimization! The changes look good and CI passes. Please ensure that the pyproject.toml reflects the required Python >=3.8 version and add a test case (e.g., in tests/test_fail_fast.py or a new test) that verifies behavior is unchanged for functools.partial-wrapped coroutines and regular functions. Once those are addressed, this PR is ready to merge. Reviewed — quality: medium |
Thanks for the review!
|
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
Hey @shenald-dev, heads up — this PR has merge conflicts with To fix: |
I have successfully fetched and merged |
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
PR is well-structured, includes necessary tests and updates pyproject.toml for Python 3.8+. The optimization is clear and CI passes. Reviewed — quality: high |
Acknowledged. |
Replaced manual iteration and unwrapping of
functools.partialinengine.pywith directinspect.iscoroutinefunction(func)assignments, as Python 3.8+ supports this natively. This prevents unreachable dead code and simplifies the async evaluation hot path.PR created automatically by Jules for task 12350163539096166018 started by @shenald-dev