You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This has now been merged into Ionic: ionic-team/ionic-framework#16559
so the real value of your repo would be as an example of best practice for Angular integration,
i.e. improve the documentation.
This repo was only to show how you can use StencilJS in combination with Angular. So if the documentation (README.md) is still suitable after your changes then I would merge your updates.
Just let me know when you are thinking that it is ready. I would test it and merge it afterwards then.
@seveves
Work completed in this ticket: #8
Ready for review.
I can then update this PR, or close it and make a clean one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the Stencil build #5
Some doc changes will be needed - later after PR review.
The integration to angular still needs to be done and I am working with A7+