Improve "not defined in the header" messages#2007
Open
daviesrob wants to merge 1 commit into
Open
Conversation
Make the FILTER and INFO variants report the location (ref + pos) where the missing tag was found, to make the problem record easier to find. The FORMAT variant already did this. The Contig one is also not changed as it already reports the reference name (which will be the missing one...) and the position isn't very important in that case. For all cases, add an extra message noting that processing a file with missing headers may fail. This will only be printed once for each affected file. Signed-off-by: Rob Davies <rmd+git@sanger.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the FILTER and INFO variants report the location (ref + pos) where the missing tag was found, to make the problem record easier to find. The FORMAT variant already did this. The Contig one is also not changed as it already reports the reference name (which will be the missing one...) and the position isn't very important in that case.
For all cases, add an extra message noting that processing a file with missing headers may fail. This will only be printed once for each affected file.