FEATURE: add Ruby-to-JS Uint8Array support#406
Merged
SamSaffron merged 2 commits intomainfrom Apr 16, 2026
Merged
Conversation
Introduce MiniRacer::Binary for attached Ruby callbacks that need to return raw bytes to JavaScript. The C extension now serializes this wrapper as a Uint8Array, and TruffleRuby is updated to mirror the same conversion path. Also add documentation, tests, and bump the version to 0.20.1.
davidtaylorhq
approved these changes
Apr 16, 2026
Collaborator
davidtaylorhq
left a comment
davidtaylorhq
left a comment
There was a problem hiding this comment.
Looks good to me. Perhaps this should be 0.21.0, since it introduces a new feature?
Collaborator
Author
|
sure I can do a bump... |
This was referenced May 1, 2026
SamSaffron
pushed a commit
that referenced
this pull request
May 4, 2026
* Improve error messages when running on TruffleRuby * Adapt test_binary_returns_uint8array to not assume that Uint8Array are converted to String * This fixes #409. * The test was added in #406. * Cleanup truffleruby CI job * Add timeout to avoid a hang to take 6 hours. * A single job on macOS seems enough. * Remove no longer necessary bundler update and TRUFFLERUBYOPT. * Add test for converting a JS Uint8Array to Ruby and implement it on TruffleRuby
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce MiniRacer::Binary for attached Ruby callbacks that need to
return raw bytes to JavaScript. The C extension now serializes this
wrapper as a Uint8Array, and TruffleRuby is updated to mirror the same
conversion path.
Also add documentation, tests, and bump the version to 0.20.1.