chore: add Rslint linting

.github/workflows/ci.yml

@@ -36,5 +36,8 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
 
+      - name: Run lint
+        run: pnpm lint
+
       - name: Run tests
         run: pnpm test

.vscode/extensions.json

@@ -0,0 +1,3 @@
+{
+  "recommendations": ["rstack.rslint"]
+}

package.json

@@ -18,6 +18,8 @@
   "scripts": {
     "build": "rslib",
     "dev": "rslib -w",
+    "lint": "rslint",
+    "lint:write": "rslint --fix",
     "prebundle": "node ./bin.js",
     "prepare": "rslib",
     "bump": "npx bumpp",
@@ -34,6 +36,7 @@
   "devDependencies": {
     "@astrojs/sitemap": "^3.7.2",
     "@rslib/core": "0.21.3",
+    "@rslint/core": "^0.5.2",
     "@rstest/core": "^0.9.10",
     "@types/fs-extra": "^11.0.4",
     "@types/node": "24.12.2",

rslint.config.ts

@@ -0,0 +1,9 @@
+import { defineConfig, js, ts } from '@rslint/core';
+
+export default defineConfig([
+  {
+    ignores: ['compiled/**'],
+  },
+  js.configs.recommended,
+  ts.configs.recommended,
+]);

src/helper.ts

@@ -20,7 +20,7 @@ export function findDepPath(name: string) {
     }
 
     return entry;
-  } catch (err) {
+  } catch {
     return null;
   }
 }
@@ -156,7 +156,9 @@ export function findDirectTypeFile(filepath: string) {
     for (const f of list) {
       try {
         return require.resolve(f, { paths: [cwd] });
-      } catch {}
+      } catch {
+        continue;
+      }
     }
   };
   switch (ext) {

src/prebundle.ts

@@ -53,13 +53,30 @@ async function emitIndex(code: string, distPath: string, prettier?: boolean) {
   }
 }
 
-const getTypes = (json: Record<string, string>): string | null =>
+type PackageJsonLike = {
+  types?: unknown;
+  typing?: unknown;
+  typings?: unknown;
+  exports?: {
+    '.'?: PackageJsonLike;
+  };
+};
+
+const getPackageJsonField = (
+  json: PackageJsonLike,
+  key: 'types' | 'typing' | 'typings',
+) => {
+  const value = json[key];
+  return typeof value === 'string' ? value : null;
+};
+
+const getTypes = (json: PackageJsonLike | null | undefined): string | null =>
   (json &&
-    (json.types ||
-      json.typing ||
-      json.typings ||
+    (getPackageJsonField(json, 'types') ||
+      getPackageJsonField(json, 'typing') ||
+      getPackageJsonField(json, 'typings') ||
       // for those who use `exports` only
-      getTypes((json as any).exports?.['.']))) ||
+      getTypes(json.exports?.['.']))) ||
   null;
 
 async function emitDts(task: ParsedTask, externals: Record<string, string>) {
@@ -145,7 +162,7 @@ async function emitDts(task: ParsedTask, externals: Record<string, string>) {
             // Avoid extra work
             checkJs: false,
             // Ensure we can parse the latest code
-            // @ts-expect-error
+            // @ts-expect-error rollup-plugin-dts accepts task target values.
             target: task.target,
           },
         }),
@@ -210,7 +227,9 @@ function emitPackageJson(
         // will be `{"type":"module"}` if the output is of esm format
         pick(JSON.parse(assets['package.json'].source), ['type']),
       );
-    } catch {}
+    } catch {
+      // Keep the picked package fields when ncc emits non-JSON metadata.
+    }
   }
 
   fs.outputFileSync(outputPath, JSON.stringify(pickedPackageJson, null, 2));