perf: clear generated primitive arrays with slice deletion#260
Open
Lidang-Jiang wants to merge 1 commit intoros2:rollingfrom
Open
perf: clear generated primitive arrays with slice deletion#260Lidang-Jiang wants to merge 1 commit intoros2:rollingfrom
Lidang-Jiang wants to merge 1 commit intoros2:rollingfrom
Conversation
Signed-off-by: Lidang Jiang <lidangjiang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the generated Python array reset loop with
PySequence_DelSlice()when converting primitive sequences to Python, and add regression coverage for bounded and unbounded primitive sequence conversion.Closes #255
Before
After
Test plan
git diff --checkpython3 -m py_compile rosidl_generator_py/test/test_interfaces.pyruff check rosidl_generator_py/test/test_interfaces.pyrosidl_generator_py.msgis generated by the ROS build/test setup and is not present in this source checkout