Skip to content

Add optional bounds type field to GetEntityBounds request#29

Open
ayushgnv wants to merge 2 commits intoros-simulation:mainfrom
ayushgnv:ayushg/add_bounds_type_request
Open

Add optional bounds type field to GetEntityBounds request#29
ayushgnv wants to merge 2 commits intoros-simulation:mainfrom
ayushgnv:ayushg/add_bounds_type_request

Conversation

@ayushgnv
Copy link
Copy Markdown
Member

@ayushgnv ayushgnv commented May 2, 2026

Adds an optional type field to GetEntityBounds.srv so callers can specify their preferred bounding box representation (box, sphere, convex hull). If unset, it defaults to TYPE_UNSPECIFIED (255), preserving existing behavior where the simulator picks the type.

Also adds the TYPE_UNSPECIFIED constant to Bounds.msg as a clean sentinel value for use in requests, distinct from the existing response types.

Closes #26.

@ayushgnv ayushgnv requested review from a team, adamdbrw and azeey May 2, 2026 02:31
@ayushgnv ayushgnv self-assigned this May 2, 2026
@peci1
Copy link
Copy Markdown
Contributor

peci1 commented May 2, 2026

Is there some real use case for autoselection of the bounds type? I can't really imagine downstream code asking for "some" bounds.

But I agree with the addition of the type to the request

@ayushgnv
Copy link
Copy Markdown
Member Author

ayushgnv commented May 2, 2026

Is there some real use case for autoselection of the bounds type? I can't really imagine downstream code asking for "some" bounds.

But I agree with the addition of the type to the request

@peci1
I was not sure if all simulators should be forced to support one of the types such as TYPE_BOX by default. A simulator could choose to have a different default from other simulators and so that's where this auto selection option might comes in handy.

If we agree as a standard to support a default type for all simulators, I'm happy with setting this option to that default type moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does it make sense to an option on what type of bbox is desired by the user

2 participants