add --wait-for-airgap to release promote#721
Merged
bennyyang11 merged 5 commits intoMay 13, 2026
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 990ee80. Configure here.
laverya
reviewed
May 13, 2026
Comment on lines
+118
to
+126
| // The vandoor API always returns airgapBuilds[] for promoted channels (metadata | ||
| // generation runs for every channel-release). This branch fires when talking to | ||
| // an older server that did not populate the field, or if the response object is | ||
| // nil for any reason — both must short-circuit before the range below to avoid | ||
| // a nil-pointer dereference. | ||
| if promoteResp == nil || len(promoteResp.AirgapBuilds) == 0 { | ||
| log.ActionWithoutSpinner("No airgap build status reported by the API (older server, or no channels were promoted)") | ||
| return nil | ||
| } |
Member
There was a problem hiding this comment.
I would remove the things talking about an "older server"
laverya
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--wait-for-airgaptorelease promoteandrelease create --promotefor KOTS apps. When set, the CLI polls the new airgap status endpoint and exits non-zero if any channel-release ends in a terminal failure (failed,failed_with_metadata,cancelled,warn). Default off, configurable timeout via--wait-for-airgap-timeout(default 30m).Also surfaces airgap data in two read commands: an
AIRGAP BUNDLESsection onrelease inspectandAIRGAP_STATUS/AIRGAP_ERRORcolumns onchannel releases.Closes the "misleading success" gap where promote returns 200 but the asynchronous airgap build silently fails.