-
Notifications
You must be signed in to change notification settings - Fork 1.7k
added the missing tests (and verified they pass) #6170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+80
−10
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,50 @@ | ||
| def TestState(State): | ||
| pass | ||
| from __future__ import annotations | ||
|
|
||
| import asyncio | ||
|
|
||
| def test_compile_state(): | ||
| # TODO: Implement test for compile_state function. | ||
| pass | ||
| import pytest | ||
|
|
||
| from reflex.compiler.utils import compile_state | ||
| from reflex.constants.state import FIELD_MARKER | ||
| from reflex.state import State | ||
| from reflex.vars.base import computed_var | ||
|
|
||
|
|
||
| class CompileStateState(State): | ||
| """State fixture exercising async computed vars during compile_state.""" | ||
|
|
||
| a: int = 1 | ||
| b: int = 2 | ||
|
|
||
| @computed_var | ||
| async def async_value(self) -> str: | ||
| """Return a resolved value after yielding to the event loop. | ||
|
|
||
| Returns: | ||
| The resolved string value. | ||
| """ | ||
| await asyncio.sleep(0) | ||
| return "resolved" | ||
|
|
||
|
|
||
| def _get_state_values(compiled: dict, state: type[State]) -> dict: | ||
| return compiled[state.get_full_name()] | ||
|
|
||
|
|
||
| def test_compile_state_resolves_async_computed_vars_without_event_loop(): | ||
| compiled = compile_state(CompileStateState) | ||
| values = _get_state_values(compiled, CompileStateState) | ||
| assert values[f"a{FIELD_MARKER}"] == 1 | ||
| assert values[f"b{FIELD_MARKER}"] == 2 | ||
| assert values[f"async_value{FIELD_MARKER}"] == "resolved" | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_compile_state_resolves_async_computed_vars_with_running_event_loop(): | ||
| assert asyncio.get_running_loop() is not None | ||
| await asyncio.sleep(0) | ||
| compiled = compile_state(CompileStateState) | ||
| values = _get_state_values(compiled, CompileStateState) | ||
| assert values[f"a{FIELD_MARKER}"] == 1 | ||
| assert values[f"b{FIELD_MARKER}"] == 2 | ||
| assert values[f"async_value{FIELD_MARKER}"] == "resolved" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.