Skip to content

[CodeQuality] Skip multiple uses variable as arg after defined on BareCreateMockAssignToDirectUseRector#669

Merged
TomasVotruba merged 6 commits intomainfrom
skip-multiple-uses
Apr 29, 2026
Merged

[CodeQuality] Skip multiple uses variable as arg after defined on BareCreateMockAssignToDirectUseRector#669
TomasVotruba merged 6 commits intomainfrom
skip-multiple-uses

Conversation

@samsonasik
Copy link
Copy Markdown
Member

When used multiple times as argument value, it can already changed on caller, so this should be skipped.

        $someMock = $this->createMock(SomeClass::class);

        // behaviour can already changed on first use
        $this->useMock($someMock);
        $this->useMockAgain($someMock);

This PR skip it, this example happen in our project ;)

@samsonasik samsonasik requested a review from TomasVotruba April 29, 2026 07:17
@samsonasik
Copy link
Copy Markdown
Member Author

@TomasVotruba ready 👍

@TomasVotruba
Copy link
Copy Markdown
Member

LGTM 👍

@TomasVotruba TomasVotruba merged commit 501420d into main Apr 29, 2026
7 checks passed
@TomasVotruba TomasVotruba deleted the skip-multiple-uses branch April 29, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants