Adding an age filter to the breakpoint command#35
Closed
mamazu wants to merge 1 commit intorectorphp:mainfrom
Closed
Adding an age filter to the breakpoint command#35mamazu wants to merge 1 commit intorectorphp:mainfrom
mamazu wants to merge 1 commit intorectorphp:mainfrom
Conversation
mamazu
force-pushed
the
adding_age_filter
branch
from
a40e54d to
d10ee6b
Compare
Contributor
Author
|
Yeah the argument parsing isn't working correct. I don't know the package to know if I need to specify any added argument to the command as well? I added the argument, and the doc block. |
Member
|
Looks good, thank you 👍 I've cherry picked it in #37 and made CI pass |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
In some packages there are many releases in a short period of time. So we want to only show packages that are at least a certain age and hopefully more stable.
What I did
Adding a filter argument to the
BreakpointCommandto filter for package age.However this doesn't work. For some reason this parameter is =1 when it's provided and
nullwhen it's not provided.