[codex] add list content card bounds css vars#387
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
==========================================
+ Coverage 99.17% 99.20% +0.02%
==========================================
Files 13 13
Lines 1336 1377 +41
Branches 178 185 +7
==========================================
+ Hits 1325 1366 +41
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request introduces the tracking and exposure of the top notification's bounds within the notification list. It updates the useListPosition hook to calculate these bounds and passes them down to the Content component, which then sets --notification-top and --notification-bottom CSS variables. This includes logic to adjust coordinates for bottom-aligned placements and a new test case to verify the style application. I have no feedback to provide.
Summary
Expose the front notification card bounds on the list content element as CSS custom properties.
--notification-topand--notification-bottomonto.rc-notification-list-content.Validation
npm test -- tests/index.test.tsxnpm testnpm run lint(passes with existing hook dependency warnings)npx tsc --noEmit