Fix error message for type application on non-generic expressions#21295
Open
achbj wants to merge 1 commit intopython:masterfrom
Open
Fix error message for type application on non-generic expressions#21295achbj wants to merge 1 commit intopython:masterfrom
achbj wants to merge 1 commit intopython:masterfrom
Conversation
Update the error message "Type application is only supported for generic classes" to also mention type aliases, since type application is also valid for generic type aliases. Fixes python#20927. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: Tanjun (https://github.com/FasterSpeeding/Tanjun)
- tanjun/commands/menu.py:63: error: Type application is only supported for generic classes [misc]
+ tanjun/commands/menu.py:63: error: Type application is only supported for generic classes and type aliases [misc]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the error message "Type application is only supported for generic classes" to also mention type aliases, since type application is also valid for generic type aliases.
The original error message was misleading because it stated that type application is only supported for generic classes, but type aliases also support type application (e.g.,
type TA[T] = list[T]; v: TA[int]works correctly).Changes
ONLY_CLASS_APPLICATIONerror message inmypy/message_registry.pyfrom "Type application is only supported for generic classes" to "Type application is only supported for generic classes and type aliases"test-data/unit/check-generics.testtest-data/unit/check-parameter-specification.testtest-data/unit/check-typevar-tuple.testTest plan
pytest mypy/test/testcheck.py::TypeCheckSuite::check-generics.test- all 194 tests passedpytest mypy/test/testcheck.py::TypeCheckSuite::check-parameter-specification.test- tests passedpytest mypy/test/testcheck.py::TypeCheckSuite::check-typevar-tuple.test- tests passed🤖 Generated with Claude Code