Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR brings in pyscript/pyscript#2470 but, "when in Rome", I took the chance to prepare a bumped minor version that bahind major
0should be handled as breaking change.Here what changed:
experimental_remote_packagehas been proven extremely valuable but it requires some orchestration around the based/root URL from where such module is retrieved, so that it can work also locally or through relative URLs without issuesIn short, what supposed to be an overall update of this module, also removing every possible warning from npm due latest gotchas here and there in that ecosystem, I feel like it's about the time to salute other runtimes at least until these get more stable and adopted.
For simplicity sake, I am not removing entirely these files (it might happen in the future) but the dist version should actually take care of dropping any unnecessary code (tree-shaking) so ... win,win?