Skip to content

WIP: add ble connect timeout#1430

Open
dlech wants to merge 1 commit intomasterfrom
ble-connect-timeout
Open

WIP: add ble connect timeout#1430
dlech wants to merge 1 commit intomasterfrom
ble-connect-timeout

Conversation

@dlech
Copy link
Copy Markdown
Member

@dlech dlech commented Jan 10, 2023

TODO:

Issue: pybricks/support#911

TODO:
- https://crbug.com/1406311 needs to be fixed
- timeout needs to be added to bootloader connect as well

Issue: pybricks/support#911
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 10, 2023

Codecov Report

❌ Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.27%. Comparing base (0db20ce) to head (3f24c35).
⚠️ Report is 920 commits behind head on master.

Files with missing lines Patch % Lines
src/ble/sagas.ts 64.70% 6 Missing ⚠️
src/ble/alerts/FailedToConnect.tsx 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1430      +/-   ##
==========================================
- Coverage   69.33%   69.27%   -0.06%     
==========================================
  Files         194      195       +1     
  Lines        4878     4899      +21     
  Branches     1010     1012       +2     
==========================================
+ Hits         3382     3394      +12     
- Misses       1469     1478       +9     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dlech
Copy link
Copy Markdown
Member Author

dlech commented Oct 13, 2025

This should be unblocked by https://chromium-review.googlesource.com/c/chromium/src/+/6798921

@dlech dlech marked this pull request as ready for review October 13, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants