Example: JS pusher.trigger() returns a Promise and should be awaited#357
Open
RWebster-Noble wants to merge 1 commit intopusher:mainfrom
Open
Example: JS pusher.trigger() returns a Promise and should be awaited#357RWebster-Noble wants to merge 1 commit intopusher:mainfrom
RWebster-Noble wants to merge 1 commit intopusher:mainfrom
Conversation
|
@RWebster-Noble is attempting to deploy a commit to the Pusher Team on Vercel. A member of the Team first needs to authorize it. |
RWebster-Noble
changed the title
…ns a Promise and should be awaited
RWebster-Noble
force-pushed
the
js-await
branch
from
d5362e3 to
4d6efe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many javascript examples code blocks are missing
await.The server-side node.js pusher.trigger(...) and pusher.sendToUser(...) functions return a Promise and should be awaited.
This should be represented in the documentation.
If this call is not awaited then the calls can become unreliable.
Also fixed a minor inconsistency where some node.js code blocks were marked as 'js'