chore: hygiene cluster — LICENSE + audit-fail + enforcing verify-netcup#43
Open
chore: hygiene cluster — LICENSE + audit-fail + enforcing verify-netcup#43
Conversation
…ify-netcup Three small wins from `docs/agent-fleet/bugs.md`: ## #34 — `LICENSE` file added `package.json` declared MIT but the repo carried no LICENSE at root. Standard MIT text added with copyright "PulseEngine, 2026". Wave-1 supply-chain reviewer's finding. ## #23 — `npm audit` no longer swallows findings `.github/workflows/ci.yml` had `npm audit --audit-level=moderate || true`, which silently kept builds green even with known CVEs. Dropped the `|| true` so moderate-or-higher findings actually fail the gate. Wave-1 supply-chain. ## #33 — `verify-netcup-deployment.sh` is now enforcing The previous version's checks were `echo` lines that never exited non-zero unless core files were missing. Wave-1 DevOps agent flagged it as theatre. Rewritten with `set -euo pipefail`, `fail`/`ok` helpers, env-var presence check (canonical AND legacy names), and `WEBHOOK_SECRET != "development"` guard so a misconfigured `.env` never reaches `pm2 start`. ## Test plan - [x] 834 tests pass - [x] eslint clean - [x] `bash -n verify-netcup-deployment.sh` clean - [ ] After merge: `npm audit` would fail the next CI run if a moderate finding exists in the lockfile. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small wave-1 fixes:
Bug fix: rulesets empty-contexts + skip control-surface repos in config #34:
LICENSEadded at repo root (MIT, matchespackage.json).Bug fix: apply dependabot config via PR (branch protection blocks direct push) #23: drop
|| truefromnpm auditstep in CI — moderate findings now fail the build.Bug feat: ChatOps issue forms — click-and-submit instead of slash commands #33:
verify-netcup-deployment.shrewritten to be enforcing (set -e, fail/ok helpers, env-var + secret check).834 tests pass
eslint clean
bash -n clean
🤖 Generated with Claude Code