Fix test on Windows#905
Open
martincostello wants to merge 1 commit intoprometheus:mainfrom
Open
Conversation
Fix test that fails on Windows. Signed-off-by: martincostello <martin@martincostello.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes a targeted test fix for cross-platform compatibility in the HTTP client config tests. It updates the missing bearer token assertion so the test no longer depends on OS-specific file-open error text, which fits the codebase’s existing focus on wrapping lower-level I/O errors with stable higher-level messages.
Changes:
- Relax the string assertion in
TestMissingBearerAuthFileto check only the stable wrapped portion of the error. - Add an
os.ErrNotExistassertion so the test still verifies the underlying failure precisely across platforms.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test that fails on Windows found while working on #904.