feat: adapted construct-x connector helm chart configurations#5
feat: adapted construct-x connector helm chart configurations#5saudkhan116 wants to merge 2 commits into
Conversation
sb-embeteco
left a comment
sb-embeteco
left a comment
There was a problem hiding this comment.
Both deployment options (consumer and provider) worked on my cluster using the deployments from the Construct-X IdentityHub Helm chart PR; see the PR comment in the IdentityHub repository.
Questions:
- Would the deployment using the legacy values file and Tractus-X container still work after the deployment files have been updated to use the Conststruct-X EDC Testbed Container? If not, we might want to consider opening a separate Chart for the Con-X Testbed and restore the Tractus-X Chart.
Notes:
- Since I'm using Istio as the ingress controller on my cluster, I wasn't able to explicitly test the ingress block in the values files. However, I don't think the changes to the configuration will have a negative impact on the deployment.
- The README can no longer be fully applied to the new deployment and should be updated to reflect using the new values files.
There was a problem hiding this comment.
This File is missing a License Header.
There was a problem hiding this comment.
This File is missing a License Header.
| controlplane: | ||
| nameOverride: "consumer-conn-controlplane" | ||
| fullnameOverride: "" | ||
| enabled: true |
There was a problem hiding this comment.
controlplane.nameOverride, controlplane.fullnameOverride and controlplane.enabled do not appear to have been implemented yet. The same applies to these keys in dataplane block and the corresponding entries in the provider values file.
| port: 9030 | ||
| # -- path for incoming api calls | ||
| path: /validation | ||
| # -- dsp api, use |
There was a problem hiding this comment.
NIT: wrong comments in line 194 and 200. Same applies to provider values file.
| - default | ||
| - protocol | ||
| - management | ||
| - dsp |
There was a problem hiding this comment.
controlplane.ingresses[0].endpoints dsp endpoint not configured in controlplane.endpoints. Also applies to provider values file.
| port: 9510 | ||
| # -- path for incoming api calls | ||
| path: /management | ||
| # -- authentication key, must be attached to each request as `X-Api-Key` header |
There was a problem hiding this comment.
NIT: comment implies authKey. Also applies to provider values file.
2 participants
WHAT
Briefly describe what your PR changes, which features it adds/modifies.
values-consumer.yamlandvalues-provider.yamlregistry.onstackit.cloud/constructx/con-x-controlplane-postgresql-hashicorp-vaultregistry.onstackit.cloud/constructx/con-x-dataplane-postgresql-hashicorp-vaultWHY
Briefly state why the change was necessary.
To demonstrate data exchange using Construct-X connectors and ensure compatibility between IdentityHub, Issuer-service and portal registration service.
FURTHER NOTES
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Closes # <-- insert Issue number if one exists