Skip to content

refactor: remove lib, lib-esm references#7853

Open
joshblack wants to merge 1 commit into
mainfrom
docs/remove-lib-esm-references
Open

refactor: remove lib, lib-esm references#7853
joshblack wants to merge 1 commit into
mainfrom
docs/remove-lib-esm-references

Conversation

@joshblack
Copy link
Copy Markdown
Member

Closes #7482

Changelog

New

Changed

  • Remove lib, lib-esm references from project

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This is an internal change to config files

Copilot AI review requested due to automatic review settings May 19, 2026 16:07
@joshblack joshblack requested a review from a team as a code owner May 19, 2026 16:07
@joshblack joshblack requested a review from siddharthkp May 19, 2026 16:07
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

⚠️ No Changeset found

Latest commit: 497da60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up remaining build/tooling configuration references to the legacy lib/ and lib-esm/ output folders, aligning the repo with the current dist/-only build output model.

Changes:

  • Remove lib/ and lib-esm/ from Turbo build outputs and from various tooling ignore/exclude lists (ESLint, Stylelint, Prettier, Vitest, setup script).
  • Update an exports-parsing example comment to reference ./dist/* instead of ./lib-esm/*.
Show a summary per file
File Description
turbo.json Drops lib/** and lib-esm/** from build task outputs.
script/setup-react-19.mts Removes lib/lib-esm from glob ignore list; minor write formatting tweak.
packages/react/vitest.config.browser.mts Removes lib/lib-esm from Vitest browser exclude list.
packages/react/script/get-export-sizes.cjs Updates example export-map comment from lib-esm wildcard to dist wildcard.
eslint.config.mjs Removes lib/lib-esm from global ignore patterns.
.stylelintignore Removes lib/lib-esm ignore patterns for CSS.
.prettierignore Removes lib/lib-esm ignore patterns.
.gitignore Stops ignoring lib/ and lib-esm/ build folders at repo root.

Copilot's findings

  • Files reviewed: 7/8 changed files
  • Comments generated: 1

Comment thread packages/react/script/get-export-sizes.cjs
@joshblack joshblack added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test labels May 19, 2026
@joshblack joshblack enabled auto-merge May 19, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lib-esm/ is not used anymore, hence references to it could/should be removed as appropriate

3 participants