改行や空白だけの行の時にエラーになる問題を修正#8
Merged
Merged
Conversation
katamotokosuke
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
n-transfer-uiでQAしていただいた時に見つかったバグの修正です。
ファイル末尾の改行などで空やスペースだけの行がある時にエラーになってしまっていたため、
そのチェック処理とユニットテストを追加しました。
動作確認内容
このブランチからテスト用のタグを作り、ローカルのn-transfer-uiで問題が改善していることを確認しました。
https://github.com/primenumber-dev/embulk-parser-jsonl/blob/master/example/sample.json をGCSに配置
→Bigqueryへのデータ転送が正常に完了し、転送されたデータもsample.jsonと同じ内容が入っていること