Add docs manifests for configuring web app versions of our sites#735
Add docs manifests for configuring web app versions of our sites#735mdo wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79f61d8246
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sizes: '180x180', | ||
| purpose: 'any', |
There was a problem hiding this comment.
This manifest only advertises 180x180 PNG icons (plus an SVG), which does not satisfy Chromium’s installability checks that require PNG icons at least 192x192 and 512x512; as a result, the sites may not be treated as installable web apps and beforeinstallprompt/install UI can be suppressed. Because this commit is specifically adding web-app manifests, this blocks the intended behavior for users trying to install the app.
Useful? React with 👍 / 👎.
mdo
force-pushed
the
mdo/web-app-manifests
branch
from
79f61d8 to
0d27814
Compare
1 participant
Testing out a little manifest generation to configure the icon, style, etc for web app versions of our sites. Most useful for DiffsHub given it's utility, but nice for the rest, too.