Add Mago as task#1216
Conversation
veewee
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I think this task in current state is not in line with other tasks. I've added some remarks inline in the code. Feel free to stat a discussion.
|
Hey @veewee, Thanks for taking the time to review the PR and share your feedback. To be fully transparent, after opening the PR I had already started reworking it to introduce 4 commands. I’ll update the PR this week with those changes; it should end up closer to how the SecurityChecker tasks are structured, which should resolve the three threads. If you have any additional feedback, feel free to share it so I can address everything at once. |
|
Hey, I just pushed a refactor splitting the The Happy to hear any feedback — whether on the option coverage, naming, documentation, or anything else that could be improved. |
This PR adds a Mago task
Mago is a recent tool that includes a formatter (like phpcs), a linter (like phpmd), and a static analyzer (like phpstan).
It is known for its performance and is starting to be increasingly adopted (for example, in Drupal).
Its integration into GrumPHP seems valuable.
New Task Checklist:
run()method readable?run()method using the configuration correctly?