ext/pdo: update pdo_set_fetch_mode_errors expect for GH-20214#21863
Closed
iliaal wants to merge 1 commit intophp:PHP-8.5from
Closed
ext/pdo: update pdo_set_fetch_mode_errors expect for GH-20214#21863iliaal wants to merge 1 commit intophp:PHP-8.5from
iliaal wants to merge 1 commit intophp:PHP-8.5from
Conversation
The phpGH-20214 setFetchMode fix (php#21434) now rejects FETCH_CLASSTYPE|FETCH_PROPS_LATE when the base fetch mode is not FETCH_CLASS. The expected output for Mode 16 in the second loop had not been updated to reflect the stricter validation, causing common.phpt failures across all PDO drivers after the fix merged up to PHP-8.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #21434. After that fix,
setFetchModerejectsFETCH_CLASSTYPE|FETCH_PROPS_LATEwhen the base mode is notFETCH_CLASS. The Mode 16 case in the second loop ofpdo_set_fetch_mode_errors.phptstill expectedbool(true), socommon.phptfails across every PDO driver once the fix merged up to PHP-8.5. This aligns the expected output with the thrownValueError.