Zend/Optimizer/block_pass.c: remove code disabled with #if 0#21791
Open
DanielEScherzer wants to merge 1 commit intophp:masterfrom
Open
Zend/Optimizer/block_pass.c: remove code disabled with #if 0#21791DanielEScherzer wants to merge 1 commit intophp:masterfrom
#if 0#21791DanielEScherzer wants to merge 1 commit intophp:masterfrom
Conversation
iluuu1994
approved these changes
Apr 22, 2026
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
We have @compile-time-eval for this purpose now. Though none of these functions actually are marked as such.
Member
Author
But, it looks like these are all handled at php-src/Zend/Optimizer/zend_optimizer.c Line 103 in 3291dea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been that way since the initial public release of the optimizer in 528006a and survived through the merging as ext/opcache (34d3202) and then moving it into core (#6642). If it hasn't been needed in the last 13 years, should be safe to drop.