Render overlay from fresh state and drop the ignore feature#15
Merged
Conversation
Three fixes that all sharpen what the overlay shows on cmd-cmd: - Remove the ignore / show-hidden feature (cmd+delete, cmd+y). The bundle+title key was unreliable across tabs and doc renames, the feature was hidden behind chords with no UI affordance, and the filtered tile list it produced was the main reason savedOrder kept drifting. - Persist drag and cmd+arrow reorders through allTiles instead of the search-filtered tiles list. savedOrder now reflects every known window, so newly-opened windows reliably append at the back. - Always render from a fresh SCShareableContent fetch on show. The prewarm-then-reconcile path is gone — no more stale tiles sliding into their final positions after every cmd-cmd. Prewarm still runs in the background to keep the framework call warm.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SCShareableContentoncmd-cmdinstead of painting the prewarm cache and animating a reconcile pass on top. The "stale tiles slide into place" flicker after every show is gone; prewarm still runs in the background to keep the framework call warm.cmd+delete,cmd+y). ThebundleID|||titlekey broke whenever a window's title changed, the feature was hidden behind chords with no settings UI, and the filtered tile list it produced was the main reasonsavedOrderdrifted.⌘+arrowreorders throughallTilesrather than the search-filteredtileslist.savedOrdernow reflects every known window, so reordering during search no longer drops hidden tiles and newly-opened windows reliably append at the back.The orphaned
ignoredWindows.<display>UserDefaults key from the removed feature is left in place — no migration needed.Test plan
⌘⌘shows the overlay with the correct tile set on the first paint; no jarring layout reflow.⌘⌘— the closed window is not shown.⌘Fto search, drag while filtered, dismiss, reopen — non-matching tiles keep their old positions; the dragged tile lands where you put it.⌘+deleteand⌘+Yare no-ops (no longer bound).