Skip to content

feat(core): expose element internals to a11y tools#3106

Open
bennypowers wants to merge 3 commits intomainfrom
feat/core/axe-core-internals-protocol
Open

feat(core): expose element internals to a11y tools#3106
bennypowers wants to merge 3 commits intomainfrom
feat/core/axe-core-internals-protocol

Conversation

@bennypowers
Copy link
Copy Markdown
Member

What I did

  1. add globalThis._elementInternals to InternalsController

When this is merged and released, a PR will be opened against RHDS to integrate it.

cc @adamjohnson @hellogreg @WilcoFiers

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 23, 2026

🦋 Changeset detected

Latest commit: a9ca7e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "feat(core): expose element internals to a11y tools"
}

@github-actions github-actions Bot added the AT passed Automated testing has passed label Apr 23, 2026
@bennypowers
Copy link
Copy Markdown
Member Author

bennypowers commented Apr 24, 2026

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit cedeb7b
😎 Deploy Preview https://deploy-preview-3106--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for bb358dd: Report

@bennypowers
Copy link
Copy Markdown
Member Author

@WilcoFiers you can see on the deploy preview page for button that globalThis._elementInternals is a weakmap pointing from pf-button elements to ElementInternals

@hellogreg
Copy link
Copy Markdown
Contributor

cc: @nikkimk

@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for cedeb7b: Report

Copy link
Copy Markdown
Collaborator

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liberating Guarded Tree Mechanics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants