Enhance run function with exit code output and update dependencies#10
Open
mirage-ctest wants to merge 8 commits into
Open
Enhance run function with exit code output and update dependencies#10mirage-ctest wants to merge 8 commits into
mirage-ctest wants to merge 8 commits into
Conversation
- Updated mocha from ^10.4.0 to ^11.3.0 - Added overrides for serialize-javascript to address CVE-2022-24785 - Created package.json.md to explain the overrides and their necessity
pkrukp
reviewed
May 20, 2026
| const hasViolations = (outcome.exitCode & 2) === 2; | ||
|
|
||
| core.setOutput("exitCode", outcome.exitCode.toString()); | ||
| core.setOutput("hasViolations", hasViolations.toString()); |
There was a problem hiding this comment.
Maybe use explicit strings "true", "false"? Now we're relying on javascript boolean to string conversion.
Suggested change
| core.setOutput("hasViolations", hasViolations.toString()); | |
| core.setOutput("hasViolations", hasViolations ? "true" : "false"); |
pkrukp
reviewed
May 20, 2026
| exitCode: | ||
| description: 'Exit code from the C/C++test analysis run.' | ||
| hasViolations: | ||
| description: 'Whether static analysis violations were found.' |
There was a problem hiding this comment.
Could we explicitly what are the possible values? (i.e. "true", "false")
So that user won't consider things like "0", "1".
Suggested change
| description: 'Whether static analysis violations were found.' | |
| description: '"true" if static analysis violations were found, "false" otherwise.' |
pkrukp
reviewed
May 20, 2026
There was a problem hiding this comment.
I very much like that this explanation was added.
I'm a little bit hesitant about the file name. But I'm not sure what'd be a better alternative.
pkrukp
reviewed
May 20, 2026
| - npm cannot satisfy both constraints simultaneously | ||
| - Using overrides avoids this resolution conflict | ||
|
|
||
| ### Result |
There was a problem hiding this comment.
I'm not sure about the purpose of this "Result" section?
Additionally, the statistics here are valid only at the moment of writing. Maybe this is something that could be part of commit message?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.