Skip to content

🎨 fix(newsletter): Remove unnecessary data attributes from newsletter… #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ludovicobesana wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

🎨 fix(newsletter): Remove unnecessary data attributes from newsletter… #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rubycon.it/_includes/newsletter.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ <h2 class="mb-4 md:mb-6" style="color: #FCF7E8; font-family: 'Noto Serif', serif
<h3 class="mb-4" style="color: #FCF7E8; font-family: 'Noto Serif', serif; font-weight: 500; font-size: 24px; line-height: 24px; letter-spacing: 0; text-transform: none;">
Stay in the loop
</h3>
<form action="https://app.convertkit.com/forms/8a5a8f8636/subscriptions" method="post" data-sv-form="8a5a8f8636" data-uid="8a5a8f8636" class="flex items-center gap-4 w-full h-[40px]" style="max-width: 448px;">
<form action="https://app.convertkit.com/forms/8a5a8f8636/subscriptions" method="post" class="flex items-center gap-4 w-full h-[40px]" style="max-width: 448px;">
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the repository style guide (lines 50 and 78), any change to a file requires updating the site_version in rubycon.it/_config.yml and adding a corresponding entry to CHANGELOG.md. Please ensure these updates are included in this pull request to maintain consistency with the project's versioning and documentation standards.

References
  1. Requirement to update site_version in _config.yml and CHANGELOG.md for every file change. (link)

<input type="email" name="email_address" placeholder="your@email.com" required class="rubicon-newsletter-input"
style="flex: 1; min-width: 0; height: 40px; border: 0; color: #FCF7E8 !important; padding: 4px 0; font-family: 'Inter', sans-serif; font-weight: 400; font-size: 20px; line-height: 32px; letter-spacing: 0;" />
<button type="submit" style="width: 120px; height: 40px; padding: 0 8px; border: 1px solid #FCF7E8; color: #FCF7E8; background: transparent; font-family: 'Noto Serif', serif; font-weight: 500; font-size: 16px; line-height: 16px; letter-spacing: 0; text-transform: none;">
Expand Down