[4/n] custom Debug impl for change to reduce review noise#16
Open
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
ahl
reviewed
May 2, 2026
Comment on lines
+60
to
+61
| .field("old_subpath", &"") | ||
| .field("new_subpath", &"") |
Collaborator
There was a problem hiding this comment.
I don't think I understand the utility of this.
Contributor
Author
There was a problem hiding this comment.
This is purely to make reviewing #19 as easy as possible:
(since in the meeting we had you gave me the feedback to minimize review noise.)
Collaborator
There was a problem hiding this comment.
sorry; I should have revisited the comments after I had looked at #19--makes sense now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're going to change the
Changestructure quite substantially in the next commit. Add a customDebugformatter first to reduce the amount of noise.There are no functional changes in this PR.