handle changes in nullability#11
Open
sunshowers wants to merge 3 commits intomainfrom
Open
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
commented
Feb 3, 2026
Comment on lines
+340
to
+342
| // honest, this seems a bit dubious. But does self.visited.insert even | ||
| // need to carry information about whether schemas are equal?) | ||
| let nullable_equal = old_schema_data.nullable == new_schema_data.nullable; |
Contributor
Author
There was a problem hiding this comment.
This is pretty dubious but doesn't change old behavior. Do we even have to track equality in the visited map?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a number of fixes to changes in nullability, found while working on some related code.
We define a notion of effective nullability in
get_effective_nullable:nullablevaluenullable || get_effective_nullable(wrapped)The effective nullability changing is an incompatible change:
Also explain in doc comments what backward and forward incompatible (and all the other variants) mean.