Fix an issue with the addcourse script.#2957
Merged
pstaabp merged 1 commit intoopenwebwork:WeBWorK-2.21from Apr 28, 2026
Merged
Conversation
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Apr 22, 2026
Update to node 24 in the build instead of node 20. Update the Perl::Tidy version to the version currently used in development. Don't install the `Statistics::R::IO` module. That is not used anymore. Update to the mariadb 10.11 docker image for the database volume. That should have been done before when I updated the docker build to Ubuntu 24. That matches the version of mariadb in Ubuntu 24. Remove the `--db-layout` option that was passed to the `addcourse` script. That is not valid for the script anymore. Note that this depends on openwebwork#2957, since the docker build will fail without the bug in the `addcourse` script fixed.
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Apr 22, 2026
Update to node 24 in the build instead of node 20. Update the Perl::Tidy version to the version currently used in development. Don't install the `Statistics::R::IO` module. That is not used anymore. Update to the mariadb 10.11 docker image for the database volume. That should have been done before when I updated the docker build to Ubuntu 24. That matches the version of mariadb in Ubuntu 24. Remove the `--db-layout` option that was passed to the `addcourse` script. That is not valid for the script anymore. Note that this depends on openwebwork#2957, since the docker build will fail without the bug in the `addcourse` script fixed.
somiaj
approved these changes
Apr 28, 2026
The `addcourse` script does not use a database object to create a user record. Instead it directly calls `WeBWorK::DB::Record::User->new(%record)`. So if the `%record` hash does not have the `accommodation_time_factor` key set, then the script errors out when it attempts to create a user. So make sure that is set.
drgrice1
force-pushed
the
bugfix/another-accommodation-time-factor-issue
branch
from
5c46f16 to
77fcce3
Compare
pstaabp
approved these changes
Apr 28, 2026
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Apr 28, 2026
Update to node 24 in the build instead of node 20. Update the Perl::Tidy version to the version currently used in development. Don't install the `Statistics::R::IO` module. That is not used anymore. Update to the mariadb 10.11 docker image for the database volume. That should have been done before when I updated the docker build to Ubuntu 24. That matches the version of mariadb in Ubuntu 24. Remove the `--db-layout` option that was passed to the `addcourse` script. That is not valid for the script anymore. Note that this depends on openwebwork#2957, since the docker build will fail without the bug in the `addcourse` script fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
addcoursescript does not use a database object to create a user record. Instead it directly callsWeBWorK::DB::Record::User->new(%record). So if the%recordhash does not have theaccommodation_time_factorkey set, then the script errors out when it attempts to create a user. So make sure that is set.It seems that
perltidywas also run on the file. I just noticed that now when I review this in preparation to create the pull request.