Fix a minor bug in the GraphTool.#1395
Merged
somiaj merged 1 commit intoopenwebwork:PG-2.21from Apr 28, 2026
Merged
Conversation
drgrice1
force-pushed
the
bugfix/jsxgraph-invalid-object
branch
from
1782906 to
c9ecb8d
Compare
pstaabp
approved these changes
Apr 28, 2026
This is a result of a workaround for a bug in the JSXGraph library and failure to properly convert all of the code in the `keyDownListener` function to work outside of the library. The `Const` object is not defined. To access those constants instead the `JXG` global object must be used.
drgrice1
force-pushed
the
bugfix/jsxgraph-invalid-object
branch
from
c9ecb8d to
e5e0bb9
Compare
somiaj
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a result of a workaround for a bug in the JSXGraph library and failure to properly convert all of the code in the
keyDownListenerfunction to work outside of the library. TheConstobject is not defined. To access those constants instead theJXGglobal object must be used.