test(bridge): add unit tests for kNoFlushModules optimisation#919
Merged
andycall merged 1 commit intoMay 8, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Commit 1eab726 introduced a performance optimisation in ModuleManager::webf_invoke_module: modules that never inspect the DOM tree (e.g. Fetch, LocalStorage, Navigator) now skip the FlushUICommand call, avoiding an expensive PostToDartSync round-trip on every invocation.
This PR adds the missing unit tests to verify the correctness of that optimisation.
Changes
Test infrastructure (bridge/test/)
Added g_flush_ui_command_call_count global counter (declared in webf_test_env.h, defined in webf_test_env.cc) so tests can observe whether flushUICommand was triggered.
Updated the TEST_flushUICommand mock to increment the counter on each call.
Registered the new test file in test.cmake.
How to test