Skip to content

Remove rabbitmq/cluster-operator/v2 dependency#1905

Open
stuggi wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
stuggi:remove_cluster_operator_dep
Open

Remove rabbitmq/cluster-operator/v2 dependency#1905
stuggi wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
stuggi:remove_cluster_operator_dep

Conversation

@stuggi
Copy link
Copy Markdown
Contributor

@stuggi stuggi commented Apr 29, 2026

Replace the typed rabbitmqv2.RabbitmqCluster usage in removeRabbitmqClusterControllerReference with unstructured client. This was the only code importing the rabbitmq cluster-operator types.

Remove the scheme registration from cmd/main.go and the CRD loading from the envtest suite. The unstructured client does not need the types registered in the scheme.

This eliminates a dependency that required a pinned replace directive and complicated OCP version bumps.

Replace the typed rabbitmqv2.RabbitmqCluster usage in
removeRabbitmqClusterControllerReference with unstructured client.
This was the only code importing the rabbitmq cluster-operator types.

Remove the scheme registration from cmd/main.go and the CRD loading
from the envtest suite. The unstructured client does not need the
types registered in the scheme.

This eliminates a dependency that required a pinned replace directive
and complicated OCP version bumps.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@openshift-ci openshift-ci Bot requested review from dprince and rabi April 29, 2026 10:57
@stuggi stuggi requested review from lmiccini and removed request for rabi April 29, 2026 10:57
@github-actions
Copy link
Copy Markdown

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 322464 bytes (315KB)
Base branch size 322464 bytes
Change +0.00%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmiccini, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a1cf86299c8742199693778ce745ab37

openstack-k8s-operators-content-provider FAILURE in 5m 55s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-edpm-baremetal-minor-update SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@lmiccini
Copy link
Copy Markdown
Contributor

recheck

@stuggi
Copy link
Copy Markdown
Contributor Author

stuggi commented Apr 29, 2026

/retest

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c939e636104b4ad781d673e6f5860750

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 17m 10s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 26m 09s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 38m 01s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 3m 45s
✔️ openstack-operator-tempest-multinode SUCCESS in 2h 01m 31s
openstack-operator-edpm-baremetal-minor-update FAILURE in 26m 58s

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

@stuggi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl-4-18 f0a8510 link true /test openstack-operator-build-deploy-kuttl-4-18

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stuggi
Copy link
Copy Markdown
Contributor Author

stuggi commented Apr 29, 2026

/retest

@stuggi
Copy link
Copy Markdown
Contributor Author

stuggi commented Apr 29, 2026

recheck

1 similar comment
@stuggi
Copy link
Copy Markdown
Contributor Author

stuggi commented Apr 29, 2026

recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdo/buildset/b1ac3c3b95f74257a5d1e74eae6e389c

openstack-k8s-operators-content-provider NODE_FAILURE Node(set) request 100-0000082662 failed in 0s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-edpm-baremetal-minor-update SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants