Skip to content

[b/r] Add singleton webhook for OpenStackBackupConfig#1904

Open
stuggi wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
stuggi:backup_restore_webhook
Open

[b/r] Add singleton webhook for OpenStackBackupConfig#1904
stuggi wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
stuggi:backup_restore_webhook

Conversation

@stuggi
Copy link
Copy Markdown
Contributor

@stuggi stuggi commented Apr 29, 2026

Add a validating webhook that enforces only one OpenStackBackupConfig instance per namespace. On create, the webhook lists existing instances and rejects the request if one already exists.

Update ReconcileBackupConfig to check for a pre-existing BackupConfig before creating the default. If a user has pre-created one, the controller uses it instead of creating a new one.

Jira: OSPRH-22912
Jira: OSPRH-22913
Jira: OSPRH-29193

Add a validating webhook that enforces only one OpenStackBackupConfig
instance per namespace. On create, the webhook lists existing instances
and rejects the request if one already exists.

Update ReconcileBackupConfig to check for a pre-existing BackupConfig
before creating the default. If a user has pre-created one, the
controller uses it instead of creating a new one.

Jira: OSPRH-22912
Jira: OSPRH-22913
Jira: OSPRH-29193

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@openshift-ci openshift-ci Bot requested review from rabi and slagle April 29, 2026 06:20
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi stuggi requested review from abays and removed request for rabi and slagle April 29, 2026 06:20
@github-actions
Copy link
Copy Markdown

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 322464 bytes (315KB)
Base branch size 322464 bytes
Change +0.00%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant