Skip to content

feat: Improve the code#686

Open
gtema wants to merge 3 commits intomainfrom
policy
Open

feat: Improve the code#686
gtema wants to merge 3 commits intomainfrom
policy

Conversation

@gtema
Copy link
Copy Markdown
Collaborator

@gtema gtema commented Apr 29, 2026

  • chore: Update policies
  • chore: Add docstrings in the core crate
  • chore: Add proper docstring to all methods

gtema added 3 commits April 28, 2026 20:42
try to ensure we enforce policies everywhere.
Hope those help to be able to better understand the purpose of function
and mainly the parameters.
@github-actions
Copy link
Copy Markdown

🦢 Load Test Results

Goose Attack Report

Plan Overview

Action Started Stopped Elapsed Users
Increasing 26-04-29 17:19:10 26-04-29 17:19:12 00:00:02 0 → 4
Maintaining 26-04-29 17:19:12 26-04-29 17:19:42 00:00:30 4
Decreasing 26-04-29 17:19:42 26-04-29 17:19:42 00:00:00 0 ← 4

Request Metrics

Method Name # Requests # Fails Average (ms) Min (ms) Max (ms) RPS Failures/s
GET 7896 5306 14.71 8 34 263.20 176.87
Aggregated 7896 5306 14.71 8 34 263.20 176.87

Response Time Metrics

Method Name 50%ile (ms) 60%ile (ms) 70%ile (ms) 80%ile (ms) 90%ile (ms) 95%ile (ms) 99%ile (ms) 100%ile (ms)
GET 11 12 21 22 23 24 27 34
Aggregated 11 12 21 22 23 24 27 34

Status Code Metrics

Method Name Status Codes
GET 5,306 [403], 2,590 [200]
Aggregated 5,306 [403], 2,590 [200]

Transaction Metrics

Transaction # Times Run # Fails Average (ms) Min (ms) Max (ms) RPS Failures/s
ListUsers
0.0 0 0 0.00 0 0 0.00 0.00
0.1 5306 0 10.84 8 19 176.87 0.00
ValidateToken
1.0 0 0 0.00 0 0 0.00 0.00
1.1 2590 0 22.75 18 34 86.33 0.00
Aggregated 7896 0 14.71 8 34 263.20 0.00

Scenario Metrics

Transaction # Users # Times Run Average (ms) Min (ms) Max (ms) Scenarios/s Iterations
ListUsers 2 5304 10.84 8 19 176.80 2652.00
ValidateToken 2 2588 22.75 18 34 86.27 1294.00
Aggregated 4 7892 14.75 8 34 263.07 3946.00

Error Metrics

Method Name # Error
GET 5489 403 Forbidden:

View full report

@github-actions
Copy link
Copy Markdown

🐰 Bencher Report

Branchpolicy
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
Command_Serde/apply/remove📈 view plot
🚷 view threshold
122,250.00 ns
(-1.22%)Baseline: 123,761.38 ns
184,097.93 ns
(66.40%)
Command_Serde/apply/set📈 view plot
🚷 view threshold
120,760.00 ns
(-6.95%)Baseline: 129,778.62 ns
193,835.65 ns
(62.30%)
Command_Serde/pack/delete📈 view plot
🚷 view threshold
120.71 ns
(-0.85%)Baseline: 121.75 ns
135.05 ns
(89.38%)
Command_Serde/pack/delete_index📈 view plot
🚷 view threshold
112.84 ns
(-1.62%)Baseline: 114.70 ns
128.75 ns
(87.64%)
Command_Serde/pack/set📈 view plot
🚷 view threshold
199.34 ns
(-1.85%)Baseline: 203.10 ns
231.34 ns
(86.17%)
Command_Serde/pack/set_index📈 view plot
🚷 view threshold
113.00 ns
(-1.93%)Baseline: 115.22 ns
131.49 ns
(85.94%)
Command_Serde/unpack/delete📈 view plot
🚷 view threshold
186.43 ns
(+1.09%)Baseline: 184.42 ns
189.83 ns
(98.21%)
Command_Serde/unpack/delete_index📈 view plot
🚷 view threshold
155.76 ns
(-3.31%)Baseline: 161.10 ns
182.42 ns
(85.39%)
Command_Serde/unpack/set📈 view plot
🚷 view threshold
246.18 ns
(+0.52%)Baseline: 244.92 ns
250.30 ns
(98.35%)
Command_Serde/unpack/set_index📈 view plot
🚷 view threshold
163.99 ns
(+3.21%)Baseline: 158.89 ns
171.41 ns
(95.67%)
Payload_encryption/pack/inner📈 view plot
🚷 view threshold
66.32 ns
(-1.13%)Baseline: 67.08 ns
78.62 ns
(84.36%)
Payload_encryption/pack/remove_cmd📈 view plot
🚷 view threshold
134.08 ns
(+5.57%)Baseline: 127.01 ns
150.81 ns
(88.91%)
Payload_encryption/pack/set_cmd📈 view plot
🚷 view threshold
242.92 ns
(+1.83%)Baseline: 238.56 ns
270.77 ns
(89.72%)
Payload_encryption/unpack/inner📈 view plot
🚷 view threshold
158.30 ns
(-2.23%)Baseline: 161.91 ns
178.66 ns
(88.60%)
Payload_encryption/unpack/remove_cmd📈 view plot
🚷 view threshold
194.66 ns
(-2.26%)Baseline: 199.17 ns
215.47 ns
(90.34%)
Payload_encryption/unpack/set_cmd📈 view plot
🚷 view threshold
253.25 ns
(-4.70%)Baseline: 265.74 ns
339.51 ns
(74.59%)
Raft_1Node_Latency/prefix/1node📈 view plot
🚷 view threshold
3,766,300.00 ns
(+11.67%)Baseline: 3,372,840.00 ns
7,120,647.11 ns
(52.89%)
Raft_1Node_Latency/read/1node📈 view plot
🚷 view threshold
576.07 ns
(+9.99%)Baseline: 523.74 ns
897.96 ns
(64.15%)
Raft_1Node_Latency/remove/1node📈 view plot
🚷 view threshold
343,130.00 ns
(-2.14%)Baseline: 350,634.00 ns
529,778.24 ns
(64.77%)
Raft_1Node_Latency/write/1node📈 view plot
🚷 view threshold
335,400.00 ns
(-5.39%)Baseline: 354,509.00 ns
547,032.89 ns
(61.31%)
build_snapshot/default📈 view plot
🚷 view threshold
91,603.00 ns
(+6.05%)Baseline: 86,378.50 ns
99,566.25 ns
(92.00%)
fernet token/project📈 view plot
🚷 view threshold
1,502.70 ns
(+1.94%)Baseline: 1,474.13 ns
1,557.81 ns
(96.46%)
get_data_keyspace📈 view plot
🚷 view threshold
0.31 ns
(-2.29%)Baseline: 0.32 ns
0.36 ns
(85.96%)
get_db📈 view plot
🚷 view threshold
0.31 ns
(-1.75%)Baseline: 0.32 ns
0.36 ns
(86.22%)
get_fernet_token_timestamp/project📈 view plot
🚷 view threshold
159.14 ns
(+5.78%)Baseline: 150.44 ns
170.90 ns
(93.12%)
get_keyspace📈 view plot
🚷 view threshold
4.35 ns
(-0.88%)Baseline: 4.39 ns
4.95 ns
(87.83%)
🐰 View full continuous benchmarking report in Bencher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant