[release-4.21] OCPBUGS-84967: Add bottom pagination to ConsoleDataView for mobile responsiveness#16396
Conversation
…sponsiveness The ConsoleDataView component was missing bottom pagination, which is required by PatternFly design guidelines for proper mobile responsiveness. On mobile viewports, the top pagination condenses to just an item count, so full pagination controls must be available in the footer/bottom. This change adds a Pagination component with variant="bottom" after the DataViewTable to ensure pagination controls remain accessible on all viewport sizes. Additionally, adds complete i18n support to both top and bottom pagination components with proper aria-labels for navigation buttons (first, previous, next, last pages) and translated visible text (ofWord, itemsPerPage, perPageSuffix) to ensure full accessibility and internationalization. (cherry picked from commit 262fa86) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@rhamilto: This pull request references Jira Issue OCPBUGS-84967, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@rhamilto: This pull request references Jira Issue OCPBUGS-84967, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by @rhamilto |
|
@rhamilto: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/jira refresh |
|
@rhamilto: This pull request references Jira Issue OCPBUGS-84967, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
76c2db6
into
openshift:release-4.21
|
@rhamilto: Jira Issue Verification Checks: Jira Issue OCPBUGS-84967 Jira Issue OCPBUGS-84967 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rhamilto: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an manual cherry-pick of #16394
/assign rhamilto
Summary by CodeRabbit
New Features
UI/UX Improvements
Bug Fixes
Localization
Dependencies