OPRUN-4590: Add OLMLifecycleAndCompatibility feature gate

[perdasilva]

Summary

• Adds a new OLMLifecycleAndCompatibility feature gate for OLM lifecycle and compatibility metadata support
• Enabled in TechPreviewNoUpgrade and DevPreviewNoUpgrade feature sets for the SelfManaged cluster profile
• Regenerated payload feature gate manifests via make update-payload-featuregates

Enhancement: openshift/enhancements#1991

Test plan

• make verify-payload-featuregates passes
• make verify passes
• Gate appears as enabled in TechPreview/DevPreview SelfManaged manifests
• Gate appears as disabled in Default/OKD manifests

🤖 Generated with Claude Code

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @perdasilva! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c621e022-bf58-458e-9453-75c21a32874b

📥 Commits

Reviewing files that changed from the base of the PR and between 0e80480 and 28e5398.

📒 Files selected for processing (10)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

✅ Files skipped from review due to trivial changes (5)

• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

🚧 Files skipped from review as they are similar to previous changes (4)

• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
• features.md
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• features/features.go

---

📝 Walkthrough

Walkthrough

A new feature gate, OLMLifecycleAndCompatibility, was added: a variable registered in the feature gates registry (features/features.go) and an entry in the feature matrix (features.md). Multiple FeatureGate YAMLs were updated to include this gate—enabled for SelfManagedHA in DevPreviewNoUpgrade and TechPreviewNoUpgrade, and added to the disabled lists for several Hypershift and SelfManagedHA Default/OKD manifests.

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	New Ginkgo test file has 10 assertions lacking meaningful failure messages. Missing explicit timeouts on cluster operations.	Add failure messages to assertions (e.g., Expect(err).NotTo(HaveOccurred(), "failed to start env")) and add timeouts on cluster operations using Eventually or explicit timeout contexts.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding the OLMLifecycleAndCompatibility feature gate to the codebase.
Description check	✅ Passed	The description is directly related to the changeset, providing context about the new feature gate, its scope, and testing approach.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only feature gate config files. No test specs or Ginkgo tests modified. All test names are static with no dynamic content.
Microshift Test Compatibility	✅ Passed	No Ginkgo e2e tests are added in this PR. The changes consist of feature gate definitions in Go code and YAML manifests only. The custom check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests were added in this PR. The PR only adds feature gate definitions, documentation, YAML manifests, and standard Go unit tests. The SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR adds feature gate metadata/configuration only. No deployment manifests, pods, controllers, or scheduling constraints are introduced. Check does not apply.
Ote Binary Stdout Contract	✅ Passed	No OTE stdout contract violations found. PR adds feature gate declaration without process-level stdout writes, problematic logging calls, or suite-level code that produces JSON-corrupting output.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No Ginkgo e2e tests were added in this PR. Changes are limited to feature gate definitions and YAML configuration files. Check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.1)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@perdasilva: This pull request references OPRUN-4590 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

• Adds a new OLMLifecycleAndCompatibility feature gate for OLM lifecycle and compatibility metadata support
• Enabled in TechPreviewNoUpgrade and DevPreviewNoUpgrade feature sets for the SelfManaged cluster profile
• Regenerated payload feature gate manifests via make update-payload-featuregates

Enhancement: openshift/enhancements#1991

Test plan

• make verify-payload-featuregates passes
• make verify passes
• Gate appears as enabled in TechPreview/DevPreview SelfManaged manifests
• Gate appears as disabled in Default/OKD manifests

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[perdasilva]

/jira refresh

[openshift-ci-robot]

@perdasilva: This pull request references OPRUN-4590 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[fgiudici]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[yuqi-zhang]

Featuregate itself looks good. For Tech Preview, we do require the enhancement to be merged, even if openshift/enhancements#1991 isn't explicitly introducing an API change

[joelanford]

/lgtm

Pending @yuqi-zhang's comments about aligning the contact person handle.

[joelanford]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-ci]

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[yuqi-zhang]

Marking as shadow review complete, pending merge of openshift/enhancements#1991

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fgiudici, joelanford, yuqi-zhang
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[everettraven]

I left some comments on the EP.

The EP must be merged before the feature gate can go under TechPreviewNoUpgrade.