[ENH] V1 -> V2 Migration - Flows (module) by Omswastik-11 · Pull Request #1609 · openml/openml-python

Omswastik-11 · 2026-01-08T12:58:31Z

added a Create method in FlowAPI for publishing flow but not refactored with old publish . (Needs discussion on this)
Added tests using fake_methods so that we can test without local V2 server . I have tested the FlowsV2 methods (get and exists ) and delete and list were not implemented in V2 server so I skipped them .

codecov-commenter · 2026-01-12T13:26:15Z

Codecov Report

❌ Patch coverage is 39.47368% with 69 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.53%. Comparing base (c62bf51) to head (915b4cb).

Files with missing lines	Patch %	Lines
openml/_api/resources/flow.py	40.21%	55 Missing ⚠️
openml/flows/flow.py	26.66%	11 Missing ⚠️
openml/flows/functions.py	57.14%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1609      +/-   ##
==========================================
- Coverage   54.64%   54.53%   -0.11%     
==========================================
  Files          63       63              
  Lines        5124     5169      +45     
==========================================
+ Hits         2800     2819      +19     
- Misses       2324     2350      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

geetu040

Nicely done overall.

Omswastik-11 · 2026-01-14T18:01:01Z

Hi @geetu040 !! Can you review the pre-commit failure It was due to merge conflicts more specifically for tasks . Should I change it on my branch ?

geetu040 · 2026-01-15T09:54:51Z

Hi @geetu040 !! Can you review the pre-commit failure It was due to merge conflicts more specifically for tasks . Should I change it on my branch ?

can you try again, sync your branch with mine? It should be fixed now.

Omswastik-11 · 2026-01-15T10:14:00Z

I think that due to conflicts it did not synced properly . I have to revert it manually

geetu040

Nice overall, few changes needed. I'll look at the tests later when the implementation is final.

…into flow-migration-stacked

Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>

…into flow-migration-stacked

Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>

geetu040

sdk code look good so far, please take a look at #1575 (comment) and make changes accordingly where needed.
all tests (existing and new) should pass to make sure we are retaining the original functionality of the sdk

geetu040 · 2026-05-08T08:31:19Z

                assert subflow.flow_id == sub_flow_id

    @pytest.mark.test_server()
    def test_tagging(self):


this test in theory should work as before, if it's passing in main, it should pass here as well.

Link
What should we do here ?

The migrated FlowV1API.list() uses HTTP caching (enable_cache=True). After push_tag → list_flows(tag=tag) returns 1 result and caches it. After remove_tag, the next list_flows(tag=tag) returns the stale cached result (1 instead of 0). The old code path didn't cache flow listings.

I see, we shouldn't use cache here. See #1609

Co-authored-by: Armaghan Shakir <raoarmaghanshakir040@gmail.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

geetu040 · 2026-05-11T14:14:47Z

+@pytest.mark.test_server()
+def test_flow_v1_get(flow_v1):
+    flow = flow_v1.get(flow_id=1)
+    _validate_flow(flow)


can be ignored, see #1609 (comment)

geetu040 · 2026-05-11T14:14:42Z

+@pytest.mark.test_server()
+def test_flow_v2_get(flow_v2):
+    flow = flow_v2.get(flow_id=1)
+    _validate_flow(flow)


can be ignored, see #1609 (comment)

Co-authored-by: Armaghan Shakir <raoarmaghanshakir040@gmail.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

geetu040

Nice work @Omswastik-11.

@PGijsbers please review/merge.

Omswastik-11 changed the title ~~[ENH] V1 -> V2 Migration~~ [ENH] V1 -> V2 Migration - Flows (module) Jan 8, 2026

Omswastik-11 marked this pull request as ready for review January 8, 2026 15:09

geetu040 mentioned this pull request Jan 9, 2026

[ENH] V1 → V2 API Migration #1575

Open

18 tasks

geetu040 suggested changes Jan 13, 2026

View reviewed changes

Omswastik-11 commented Jan 14, 2026

View reviewed changes

Comment thread openml/_api/resources/flows.py Outdated

Omswastik-11 force-pushed the flow-migration-stacked branch from 614411f to 36184e5 Compare January 14, 2026 14:56

Omswastik-11 requested a review from geetu040 January 14, 2026 15:10

geetu040 suggested changes Jan 15, 2026

View reviewed changes

Comment thread openml/_api/resources/flows.py Outdated

Comment thread openml/flows/functions.py Outdated

Comment thread openml/flows/functions.py Outdated

geetu040 assigned Omswastik-11 Jan 19, 2026

Omswastik-11 requested a review from geetu040 January 21, 2026 18:25

Omswastik-11 marked this pull request as draft January 27, 2026 07:30

Omswastik-11 marked this pull request as ready for review January 27, 2026 15:13

geetu040 and others added 13 commits January 28, 2026 13:50

add test_http.py

fa53f8d

add uses_test_server marker

2b2db96

Merge branch 'migration' of https://github.com/geetu040/openml-python …

c7c24a3

…into flow-migration-stacked

implement reset_cache

c9617f9

Merge branch 'migration' of https://github.com/geetu040/openml-python …

92d88e4

…into flow-migration-stacked

tests:added tests for migration

443ade9

Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>

tests:added tests for migration

468087d

Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>

fixes with publish/delete

5bc37b8

fix cache_key in tests

08d9916

tests:added tests for migration

9660e78

Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>

Merge branch 'migration' of https://github.com/geetu040/openml-python …

f60c78b

…into flow-migration-stacked

tests:added tests for migration

f25c95b

Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>

update _not_supported

8caba11

geetu040 suggested changes Jan 30, 2026

View reviewed changes

Comment thread openml/flows/functions.py Outdated

Comment thread openml/flows/functions.py Outdated

geetu040 suggested changes May 8, 2026

View reviewed changes

geetu040 and others added 2 commits May 11, 2026 16:41

Merge branch 'main' into flow-migration-stacked

7fd3d61

Update tests/test_api/test_flow.py

2dafdf7

Co-authored-by: Armaghan Shakir <raoarmaghanshakir040@gmail.com>

Copilot AI review requested due to automatic review settings May 11, 2026 12:21

Copilot started reviewing on behalf of Omswastik-11 May 11, 2026 12:22 View session

Copilot AI reviewed May 11, 2026

View reviewed changes

Comment thread openml/flows/functions.py Outdated

Comment thread tests/test_api/test_flow.py Outdated

Comment thread openml/flows/flow.py

Comment thread openml/flows/flow.py

fix string check

edb2a74

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 11, 2026 12:29

Copilot started reviewing on behalf of Omswastik-11 May 11, 2026 12:29 View session

Omswastik-11 requested a review from geetu040 May 11, 2026 12:34

Copilot AI reviewed May 11, 2026

View reviewed changes

Comment thread tests/test_api/test_flow.py Outdated

Comment thread openml/flows/flow.py

geetu040 and others added 4 commits May 11, 2026 18:09

update tests/test_api/test_flow.py

bb68b4d

update openml/flows/flow.py

1f419d3

fix: test_flow

9afe04d

fix: test_flow

1489787

Copilot AI review requested due to automatic review settings May 11, 2026 13:17

Copilot started reviewing on behalf of Omswastik-11 May 11, 2026 13:18 View session

Copilot AI reviewed May 11, 2026

View reviewed changes

geetu040 suggested changes May 11, 2026

View reviewed changes

Comment thread tests/test_api/test_flow.py Outdated

Comment thread tests/test_api/test_flow.py Outdated

geetu040 suggested changes May 11, 2026

View reviewed changes

Comment thread openml/_api/resources/flow.py Outdated

Omswastik-11 and others added 2 commits May 11, 2026 19:47

fix: test_flow

e6d8d05

Update tests/test_api/test_flow.py

6e30a9f

Co-authored-by: Armaghan Shakir <raoarmaghanshakir040@gmail.com>

Copilot AI review requested due to automatic review settings May 11, 2026 14:18

Update openml/_api/resources/flow.py

b68dd0f

Co-authored-by: Armaghan Shakir <raoarmaghanshakir040@gmail.com>

Copilot started reviewing on behalf of Omswastik-11 May 11, 2026 14:19 View session

Omswastik-11 added 2 commits May 11, 2026 19:55

fix: test_flow

c872902

fix: test_flow

915b4cb

Omswastik-11 requested a review from geetu040 May 11, 2026 14:30

Copilot AI reviewed May 11, 2026

View reviewed changes

geetu040 approved these changes May 12, 2026

View reviewed changes

Uh oh!

Conversation

Omswastik-11 commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

geetu040 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Omswastik-11 commented Jan 14, 2026

Uh oh!

geetu040 commented Jan 15, 2026

Uh oh!

Omswastik-11 commented Jan 15, 2026

Uh oh!

geetu040 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

geetu040 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

geetu040 May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Omswastik-11 May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Omswastik-11 May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

geetu040 May 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

geetu040 May 11, 2026

Choose a reason for hiding this comment

Uh oh!

geetu040 May 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Omswastik-11 commented Jan 8, 2026 •

edited

Loading

codecov-commenter commented Jan 12, 2026 •

edited

Loading

Omswastik-11 May 11, 2026 •

edited

Loading

Omswastik-11 May 11, 2026 •

edited

Loading