feat: translate STUDIO_BASE_URL to cmsBaseUrl in frontend site config#38577
Open
arbrandes wants to merge 1 commit intoopenedx:masterfrom
Open
feat: translate STUDIO_BASE_URL to cmsBaseUrl in frontend site config#38577arbrandes wants to merge 1 commit intoopenedx:masterfrom
arbrandes wants to merge 1 commit intoopenedx:masterfrom
Conversation
arbrandes
force-pushed
the
arbrandes/translate-cms-base-url
branch
from
5b64474 to
79a05d2
Compare
Maps the legacy STUDIO_BASE_URL key to the optional frontend-base cmsBaseUrl field so it surfaces at the top level of FrontendSiteConfigView instead of falling through to commonAppConfig. Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
force-pushed
the
arbrandes/translate-cms-base-url
branch
from
79a05d2 to
47d132a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Maps the legacy
STUDIO_BASE_URLkey to the optionalcmsBaseUrlfield inSITE_CONFIG_TRANSLATION_MAP, matching frontend-base'sOptionalSiteConfiginterface. With this change,FrontendSiteConfigViewsurfaces the Studio base URL at the top level of the response rather than nesting it insidecommonAppConfig.The two
test_views.pycases that previously assertedSTUDIO_BASE_URLlived incommonAppConfignow assert it appears at the top level ascmsBaseUrl.LLM usage notice
Built with assistance from Claude.