Conversation
… page size. Continue to respond() even when we don't find an existing pending client tool call item. Bump to 1.6.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ThreadsAddClientToolOutputReq()is invoked, we raise a value error and abort the stream server-side unless the very last thread item in the current thread is a pending client tool call item.This is fragile for cases where a previous turn might add hidden context items or items added with the same created at timestamp can have swapped orders etc.
Relaxing this requirement so that:
This lets us handle a case that would've always been an error to be resilient and continue the response instead of flopping.
Tested against chatkit studio by manually appending a hidden context item after streaming a client tool call item: