Add Prometheus translation strategy support#8346
Draft
zeitlinger wants to merge 4 commits intoopen-telemetry:mainfrom
Draft
Add Prometheus translation strategy support#8346zeitlinger wants to merge 4 commits intoopen-telemetry:mainfrom
zeitlinger wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8346 +/- ##
============================================
- Coverage 90.31% 90.29% -0.03%
- Complexity 7725 7762 +37
============================================
Files 850 851 +1
Lines 23259 23352 +93
Branches 2364 2377 +13
============================================
+ Hits 21007 21085 +78
- Misses 1528 1537 +9
- Partials 724 730 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TranslationStrategysupport to the Prometheus exporter builder and declarative configclient_javato1.6.1, which provides the released naming support this needsprometheus/otlptranslatorbehavior for invalid characters, repeated underscores, and digit-leading labelsNotes
prometheus/otlptranslatorpreserves labels normalized to__...__; Prometheus Java rejects user labels starting with__, so those labels are collapsed to a valid single-underscore form instead.Test plan
./gradlew :exporters:prometheus:test --tests io.opentelemetry.exporter.prometheus.PrometheusHttpServerTest.fetchOpenMetrics --tests io.opentelemetry.exporter.prometheus.PrometheusHttpServerTest.fetchOpenMetrics_translationStrategyEnablesOm2 --tests io.opentelemetry.exporter.prometheus.PrometheusMetricReaderTest --tests io.opentelemetry.exporter.prometheus.Otel2PrometheusConverterTest --tests io.opentelemetry.exporter.prometheus.internal.PrometheusMetricReaderProviderTest :sdk-extensions:declarative-config:test --tests io.opentelemetry.sdk.autoconfigure.declarativeconfig.MetricReaderFactoryTest.create_PullPrometheusConfiguredResolves #8195